Updated refferencing cached route view on navigate #320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
suresh-gangumalla
commented
Mar 19, 2025
suresh-gangumalla
commented
- On navigating using $route.to method, always create new instance of component eventhough its already cached by keepAlive
- Not removing keepAlive pages from cache on back navigation
- Destroying non keep alive pages on route change
1. On navigating using $route.to method, always create new instance of component eventhough its already cached by keepAlive 2. Not removing keepAlive pages from cache on back navigation 3. Destroying non keep alive pages on route change Signed-off-by: Suresh Kumar Gangumalla <[email protected]>
|
Test Results Summary: (Ran at: Wed Mar 19 10:38:48 UTC 2025) |
Added feature to store multiple instances of same route hash on navigating and implemented removing & destroying specific entry as per route history Signed-off-by: Suresh Kumar Gangumalla <[email protected]>
|
Test Results Summary: (Ran at: Tue Mar 25 09:22:06 UTC 2025) |
jfboeve
reviewed
Mar 27, 2025
Signed-off-by: Suresh Kumar Gangumalla <[email protected]>
|
Test Results Summary: (Ran at: Tue Apr 8 08:42:48 UTC 2025) |
jfboeve
approved these changes
Apr 9, 2025
Collaborator
|
@suresh-gangumalla - I think this PR has been addressed differently in the v1.39.0 release? Correct? |
Collaborator
Author
|
Yes @michielvandergeest this was handled in latest release so we are good to close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.