-
Notifications
You must be signed in to change notification settings - Fork 34
Made FPScounter as on demand import #557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Made FPScounter as on demand import #557
Conversation
suresh-gangumalla
commented
Dec 18, 2025
- re-enabled FPS counter comonent
- Removed this component from being avialable by default
- One can import this into blits app by named import
1. re-enabled FPS counter comonent 2. Removed this component from being avialable by default 3. One can import this into blits app by named import Signed-off-by: Suresh Kumar Gangumalla <[email protected]>
Test Results: ❌ FAILEDRun at: 2025-12-18T07:41:39.559Z Summary: Error Output: |
Signed-off-by: Suresh Kumar Gangumalla <[email protected]>
Test Results: ✅ PASSEDRun at: 2025-12-18T10:01:47.839Z Summary: |
Test Results: ✅ PASSEDRun at: 2025-12-24T11:45:51.772Z Summary: |
michielvandergeest
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like the on demand import isn't working properly because the renderer isn't instantiated yet when the computed first runs. We should review this, and possibly revert to the built-in component structure (where the component is deliberately wrapped inside a function to prevent premature instantiation)