Skip to content

Account for Arcs and lazy being dropped #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 10, 2025
Merged

Account for Arcs and lazy being dropped #651

merged 5 commits into from
Oct 10, 2025

Conversation

@tnull
Copy link
Collaborator

@tnull tnull commented Sep 25, 2025

Based on #650.

We fix two more minor API changes that have been merged on LDK.

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Sep 25, 2025 •
edited
Loading

I've assigned @jkczyz as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@tnull tnull marked this pull request as draft September 25, 2025 14:24
@tnull tnull changed the base branch from main to develop September 30, 2025 07:53
@tnull tnull force-pushed the 2025-09-fix-lazy-remove branch from 6129097 to 3c695a0 Compare September 30, 2025 08:17
@tnull tnull changed the base branch from develop to main October 7, 2025 08:52
@tnull
Copy link
Collaborator Author

tnull commented Oct 7, 2025

We decided to make the develop behavior (tracking more-recent LDK main) the default behavior. With #655 we merged develop into main and now deleted the develop branch. Hence the base branch is changed to main here, too.

@tnull tnull force-pushed the 2025-09-fix-lazy-remove branch from 3c695a0 to 9ec89fe Compare October 8, 2025 09:48
@tnull
Copy link
Collaborator Author

tnull commented Oct 8, 2025

Rebased on main now that #650 has been merged. Ready for review.

@tnull tnull marked this pull request as ready for review October 8, 2025 09:48
@tnull tnull added this to the 0.7 milestone Oct 8, 2025
@ldk-reviews-bot ldk-reviews-bot requested a review from jkczyz October 8, 2025 09:49
@tnull tnull moved this to Goal: Merge in Weekly Goals Oct 9, 2025
@tnull tnull self-assigned this Oct 9, 2025
jkczyz
jkczyz approved these changes Oct 9, 2025
View reviewed changes
Copy link
Contributor

@jkczyz jkczyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though CI is failing.

@tnull
Copy link
Collaborator Author

tnull commented Oct 10, 2025

LGTM, though CI is failing.

Yeah, very flaky currently unfortunately.

@tnull tnull merged commit 98d2148 into lightningdevkit:main Oct 10, 2025
0 of 15 checks passed
@github-project-automation github-project-automation bot moved this from Goal: Merge to Done in Weekly Goals Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkczyz jkczyz jkczyz approved these changes

Assignees

@tnull tnull

Labels

None yet

Projects

Weekly Goals
Status: Done

Milestone

0.7

Development

Successfully merging this pull request may close these issues.

3 participants

@tnull @ldk-reviews-bot @jkczyz