- 
                Notifications
    You must be signed in to change notification settings 
- Fork 421
Add fmt::Debug implementation for FundedChannel #4183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 👋 Thanks for assigning @valentinewallace as a reviewer! | 
To aid with debugging in tests.
| Codecov Report❌ Patch coverage is  
 Additional details and impacted files@@           Coverage Diff           @@
##             main    #4183   +/-   ##
=======================================
  Coverage   88.83%   88.84%           
=======================================
  Files         180      180           
  Lines      137504   137510    +6     
  Branches   137504   137510    +6     
=======================================
+ Hits       122155   122165   +10     
+ Misses      12538    12535    -3     
+ Partials     2811     2810    -1     
 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
 | 
| Outbound, | ||
| } | ||
|  | ||
| #[derive(Debug)] | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are some of these not conditional derived?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I followed the path of non-conditional derivation for non-public types, and only adding conditionals for public types or when required transitively. @TheBlueMatt mentioned offline "For internal types we should probably mostly just upstream Debug on most structs…"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. CI has some failures but look unrelated.
To aid with debugging in tests.