tapd: bump maxFeeRatio for funded psbts #1545
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 17555793621Details
💛 - Coveralls |
guggero
reviewed
May 16, 2025
GeorgeTsagk
force-pushed
the
bump-psbt-maxfeeratio
branch
from
99bb86a to
e9d48fa
Compare
GeorgeTsagk
force-pushed
the
bump-psbt-maxfeeratio
branch
from
e9d48fa to
2028e61
Compare
|
Made the value configurable by the user via |
Closed
|
@ffranr: review reminder |
|
I think after this is rebased, with the comments addressed, we can land it. |
This commit allows the user to set their own value for the maximum allowed fees to total output amount ratio that is used by the wallet when funding PSBTs.
GeorgeTsagk
force-pushed
the
bump-psbt-maxfeeratio
branch
from
68cba5f to
74a8303
Compare
jtobin
reviewed
Sep 8, 2025
| // use when funding PSBTs for asset transfers. Since taproot assets can | ||
| // be anchored to outpoints that may carry relatively small bitcoin | ||
| // amounts it is useful to pick a high value for this argument as in | ||
| // high fee environments the total fees paid may outweight the anchor |
| walletAnchor := lndservices.NewLndRpcWalletAnchor(lndServices) | ||
| walletAnchor := lndservices.NewLndRpcWalletAnchor( | ||
| lndServices, | ||
| lndservices.WithPsbtMaxFeeRatio(cfg.Wallet.PsbtMaxFeeRatio), |
There was a problem hiding this comment.
I'm guessing this eventually gets checked by lnd, but worth doing any bounds checking on the argument before we get here, possibly in tapcfg.ValidateConfig?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows the user to define the maximum ratio of fees to total output amounts that is used when funding a PSBT with our wallet. The default value is configured to be
0.75.