Skip to content

feat: update Dockerfile&add github action #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ryoppippi
Copy link

@ryoppippi ryoppippi commented Apr 18, 2025

Hi!
I tried to build lightpanda's docker image, but because of recent changes in v8 I couldn't build it. Also I found that there is no ci on Dockerfile. In addition, this dockerfile doesn't use multi-stage build efficiency.
So this pr includes

  • enhance multi-stage building
  • add ci
  • Automatic detection of cpu archtecture.

You can see the build result here

https://github.com/ryoppippi/browser/actions/runs/14534577660/job/40780436433

Copy link


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Comment on lines +106 to +108
RUN make install-libiconv
RUN make install-netsurf
RUN make install-mimalloc
Copy link
Author

@ryoppippi ryoppippi Apr 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separated the make commands because we can use build cache in each command.
We use multi-stage build so we don't have to worry about the final image size


# Build release
# Ensure git context is available for rev-parse
RUN zig build --release=safe -Doptimize=ReleaseSafe -Dgit_commit=$(git rev-parse --short HEAD)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to fix Makefile later actually...
I copy-n-pasted it from build.yml

@ryoppippi
Copy link
Author

If I need to change something, let me know! please write it down here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant