DEVOPS-3030-added-support-custom-ca #138
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moshiko-s
reviewed
Sep 18, 2025
chart/values.yaml
Outdated
| @@ -478,6 +478,7 @@ secrets: | |||
| # redis authentication. | |||
| # requires to enable auth in deployments.redis.auth.enabled by set to true | |||
| password: "" | |||
| externalCaCertificate: "" | |||
There was a problem hiding this comment.
maybe call it "CustomCaCertificate"?
There was a problem hiding this comment.
changed to customCaCertificate
chart/templates/secrets.yaml
Outdated
| name: {{ include "secrets.ca_certificate.name" . }} | ||
| type: Opaque | ||
| data: | ||
| ca.pem: {{ .Values.secrets.externalCaCertificate }} |
There was a problem hiding this comment.
maybe custom_ca.pem instead of ca.pem?
There was a problem hiding this comment.
changed to custom_ca.pem
| @@ -368,6 +375,11 @@ spec: | |||
| emptyDir: | |||
| sizeLimit: {{ .Values.general.readOnlyRootFilesystem_tmpfs_sizeLimit }} | |||
| {{ end }} | |||
| {{- if .Values.secrets.externalCaCertificate }} | |||
| - name: ca-certificate | |||
There was a problem hiding this comment.
call it custom-ca-certificate?
chart/templates/helpers/_helpers.tpl
Outdated
| @@ -509,6 +508,10 @@ Usage: | |||
| {{- end -}} | |||
| {{- end -}} | |||
|
|
|||
| {{- define "secrets.ca_certificate.name" -}} | |||
There was a problem hiding this comment.
call it custom_ca_certificate?
yonik-lr
force-pushed
the
DEVOPS-3030
branch
from
845a9a8 to
294c752
Compare
yonik-lr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.