Merge pull request #10 from lightspeeddevelopment/fix/9

- Fixed the issue `PHP Notice: Undefined index: fullscreen`,
lightspeedwp · Mar 23, 2020 · 2f14cb6 · 2f14cb6
2 parents 935360d + 557e7a0
commit 2f14cb6
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 5 deletions.
diff --git a/assets/js/views/configurator.js b/assets/js/views/configurator.js
@@ -270,11 +270,11 @@
 
 		processWidget: function( widget ) {
 			var model, childWidgetItemView, widgetExists;
-
-			if ( ! widget.id ) {
+			
+			if ( undefined == widget ) {
 				return;
 			}
-
+			model = JSON.stringify(this.model.get( 'widgets' ) );
 			model = this.model.get( 'widgets' ).get( widget.id );
 
 			// Add widget model to collection
@@ -287,7 +287,7 @@
 				if ( widgetView.id === widget.id ) {
 					return widgetView;
 				}
-
+				console.log( 'test 3' + widgetView );
 				return false;
 			});
 

diff --git a/changelog.txt b/changelog.txt
@@ -1,7 +1,12 @@
 # Change log
 
+
 ## [Unreleased] - Minor version 1.2.5
 
+### Fixed
+- Fixed the issue `PHP Notice: Undefined index: fullscreen`,
+- Fixed the issue `Uncaught TypeError: Cannot read property 'id' of undefined`.
+
 ### Security
 - General testing to ensure compatibility with latest WordPress version (5.4).
 - General testing to ensure compatibility with latest LSX Theme version (2.7).

diff --git a/includes/class-lsxmm-frontend.php b/includes/class-lsxmm-frontend.php
@@ -375,7 +375,8 @@ private function _is_mega_menu_fullscreen( $item_id ) {
 		$saved_data = get_option( 'LSXMM_DATA' );
 		if ( $saved_data && array_key_exists( intval( $item_id ), $saved_data ) ) {
 			$mega_menu = $saved_data[ intval( $item_id ) ];
-			if ( ! isset( $mega_menu['fullscreen'] ) || false === $mega_menu['fullscreen'] ) {
+
+			if ( ! isset( $mega_menu['fullscreen'] ) || false === $mega_menu['fullscreen'] || '' === $mega_menu['fullscreen'] ) {
 				return false;
 			}
 			return true;