-
Notifications
You must be signed in to change notification settings - Fork 653
Add hack/update-template-alpine.sh
#2811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
AkihiroSuda
merged 4 commits into
lima-vm:master
from
norio-nomura:update-template-alpine.sh
Oct 30, 2024
Merged
Add hack/update-template-alpine.sh
#2811
AkihiroSuda
merged 4 commits into
lima-vm:master
from
norio-nomura:update-template-alpine.sh
Oct 30, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
reviewed
Oct 28, 2024
10 tasks
_This change does not include support for `https://github.com/lima-vm/alpine-lima`._ ```console $ hack/update-template-alpine.sh update-template-alpine.sh: Update the Alpine Linux image location in the specified templates Usage: update-template-alpine.sh [--version-major-minor <major>.<minor>] <template.yaml>... Description: This script updates the Alpine Linux image location in the specified templates. Image location basename format: <target vendor>_alpine-<version>-<arch>-<firmware>-<bootstrap>[-<machine>]-<image revision>.qcow2 Published Alpine Linux image information is fetched from the following URLs: latest-stable: https://dl-cdn.alpinelinux.org/alpine/latest-stable/releases/cloud <major>.<minor>: https://dl-cdn.alpinelinux.org/alpine/v<major>.<minor>/releases/cloud To parsing html, this script requires 'htmlq' or 'pup' command. The downloaded files will be cached in the Lima cache directory. Examples: Update the Alpine Linux image location in templates/**.yaml: $ update-template-alpine.sh templates/**.yaml Update the Alpine Linux image location to version 3.18 in ~/.lima/alpine/lima.yaml: $ update-template-alpine.sh --version-major-minor 3.18 ~/.lima/alpine/lima.yaml $ limactl factory-reset alpine Flags: --version-major-minor <major>.<minor> Use the specified <major>.<minor> version. The version must be 3.18 or later. -h, --help Print this help message ``` Signed-off-by: Norio Nomura <[email protected]> # Conflicts: # hack/update-template.sh
…cache_key_for_image_kernel` functions The cache should operate on the original location in template. Signed-off-by: Norio Nomura <[email protected]>
…validation also add mention about `latest-stable` on `--version-major-minor` Signed-off-by: Norio Nomura <[email protected]>
Signed-off-by: Norio Nomura <[email protected]>
2eb0885
to
b56686c
Compare
rebased |
AkihiroSuda
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Thanks! 🙏🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change does not include support for
https://github.com/lima-vm/alpine-lima
.This PR aims to add Alpine Linux support as per #1347.