portfwdserver: fix half-close #3686
Draft
+7
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
force-pushed
the
fix-3685
branch
2 times, most recently
from
a3eb1bb to
f946103
Compare
balajiv113
previously approved these changes
Jul 4, 2025
|
Failures on WSL2 🤔 |
Fix issue 3685 Similar to 3684 Signed-off-by: Akihiro Suda <[email protected]>
nirs
reviewed
Jul 4, 2025
| proxy := tcpproxy.DialProxy{DialContext: func(_ context.Context, _, _ string) (net.Conn, error) { | ||
| return conn, nil | ||
| }} | ||
| proxy.HandleConn(rw) |
There was a problem hiding this comment.
Unlike bicopy.Bicopy(), this ignores errors silently. I don't think this library should be used for anything in the current state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3685
Similar to: