Skip to content

fix limactl run bug by treating unparseable versions as latest instead of crashing during template validation. #3820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

olamilekan000
Copy link
Contributor

@olamilekan000 olamilekan000 commented Aug 12, 2025

change fixes limactl run bug  by treating unparseable versions as latest instead of crashing
during template validation.

fixes issue

@olamilekan000 olamilekan000 force-pushed the fix-lima-failing-to-run-when-version-is-not-properly-set branch 3 times, most recently from 134232b to f2abf5c Compare August 12, 2025 02:54
@olamilekan000
Copy link
Contributor Author

olamilekan000 commented Aug 15, 2025

can someone review this? thanks @afbjorklund @jandubois

Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

However, some comment changes and an additional test should be added.

Also might be a good idea to update all the GitHub actions that do a checkout with check-depth: 0 (see #3495 (comment)). That should not be necessary after this change, otherwise there is something wrong with it.

@olamilekan000 olamilekan000 force-pushed the fix-lima-failing-to-run-when-version-is-not-properly-set branch from f2abf5c to d7155aa Compare August 16, 2025 00:38
@jandubois
Copy link
Member

Please resolve merge conflicts by rebasing on latest master

@olamilekan000 olamilekan000 force-pushed the fix-lima-failing-to-run-when-version-is-not-properly-set branch 2 times, most recently from d04237f to d65ae91 Compare August 16, 2025 00:55
Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

I see we have a bunch of checkout actions that explicitly specify fetch-depth: 1, which is redundant because it is the default. I wonder if those were added to explicitly show that we don't need the tags? I feel like they could all be removed, but should probably be done in a separate PR.

@jandubois jandubois added this to the v2.0.0 milestone Aug 16, 2025
Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the colima test is now failing: https://github.com/lima-vm/lima/actions/runs/17002343354/job/48209754473?pr=3820

 + colima start
  time="2025-08-16T03:19:41Z" level=fatal msg="lima compatibility error: invalid semver version for Lima: d65ae91 is not in dotted-tri format"

@olamilekan000
Copy link
Contributor Author

Looks like the colima test is now failing: https://github.com/lima-vm/lima/actions/runs/17002343354/job/48209754473?pr=3820

 + colima start
  time="2025-08-16T03:19:41Z" level=fatal msg="lima compatibility error: invalid semver version for Lima: d65ae91 is not in dotted-tri format"

I think it might be because it is because of this.

        ref: ${{ github.event.pull_request.head.sha }}

Let me remove it and see what happens.

@olamilekan000 olamilekan000 force-pushed the fix-lima-failing-to-run-when-version-is-not-properly-set branch from d65ae91 to 084e31b Compare August 16, 2025 03:33
@olamilekan000
Copy link
Contributor Author

Thanks, LGTM

I see we have a bunch of checkout actions that explicitly specify fetch-depth: 1, which is redundant because it is the default. I wonder if those were added to explicitly show that we don't need the tags? I feel like they could all be removed, but should probably be done in a separate PR.

Yes, I had the same thought too but I didn't want to touch them since the linked issue explicitly mentioned just fetch-depth: 0

@jandubois
Copy link
Member

I think it might be because it is because of this.

No, it is not. It is a check in colima itself that fails. It will only work with a limactl with a proper version: https://github.com/abiosoft/colima/blob/da28a8334746baa56361c05d4c0c2c1e1b2966b3/cmd/start.go#L88-L89

So for the colima test step we need to build with fetch-depth: 0. Add a comment to the step explaining why this is still required.

@olamilekan000 olamilekan000 force-pushed the fix-lima-failing-to-run-when-version-is-not-properly-set branch from 084e31b to e72cac5 Compare August 16, 2025 04:05
…d of crashing during template validation.

Signed-off-by: olalekan odukoya <[email protected]>
@olamilekan000 olamilekan000 force-pushed the fix-lima-failing-to-run-when-version-is-not-properly-set branch from e72cac5 to c492c69 Compare August 16, 2025 04:12
@jandubois jandubois merged commit 637d8fd into lima-vm:master Aug 16, 2025
62 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lima fails to run, if deleting all the git tags before building
2 participants