Skip to content

Conversation

olamilekan000
Copy link
Contributor

change adds functionality to display Plugins in the info and list commands

Fixes #3608 (comment)

@olamilekan000 olamilekan000 force-pushed the show-available-plugins-for-info-and-exec-cmd branch 3 times, most recently from 9993a6e to e012aa1 Compare September 9, 2025 11:30
@AkihiroSuda AkihiroSuda added this to the v2.0.0 milestone Sep 9, 2025
@AkihiroSuda AkihiroSuda added the area/cli limactl CLI user experience label Sep 9, 2025
@olamilekan000 olamilekan000 force-pushed the show-available-plugins-for-info-and-exec-cmd branch from e012aa1 to 6854c86 Compare September 15, 2025 00:08
@olamilekan000 olamilekan000 force-pushed the show-available-plugins-for-info-and-exec-cmd branch from 6854c86 to 51673df Compare September 15, 2025 00:12
Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked at the docs changes, but here is some feedback on the code.

Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs review

@olamilekan000 olamilekan000 force-pushed the show-available-plugins-for-info-and-exec-cmd branch 2 times, most recently from f2fea51 to 2d073bc Compare September 16, 2025 18:35
@olamilekan000 olamilekan000 force-pushed the show-available-plugins-for-info-and-exec-cmd branch from 2d073bc to ff781c8 Compare September 16, 2025 18:38
@AkihiroSuda
Copy link
Member

AkihiroSuda commented Sep 17, 2025

BATS failing

ok 38 setting both allow list and block list generates a warning in 138ms
not ok 39 limactl info includes the default block list in 124ms
# (in test file hack/bats/tests/preserve-env.bats, line 152)
#   `run -0 limactl yq '.shellEnvBlock[]' <<<"$output"' failed, expected exit code 0, got 1
# time="2025-09-17T09:21:44Z" level=warning msg="Plugin discovery: failed to scan directory /snap/bin: open /snap/bin: no such file or directory"
# time="2025-09-17T09:21:44Z" level=warning msg="Plugin discovery: failed to scan directory /home/runner/.local/bin: open /home/runner/.local/bin: no such file or directory"
# time="2025-09-17T09:21:44Z" level=warning msg="Plugin discovery: failed to scan directory /home/runner/.config/composer/vendor/bin: open /home/runner/.config/composer/vendor/bin: no such file or directory"
# time="2025-09-17T09:21:44Z" level=warning msg="Plugin discovery: failed to scan directory /snap/bin: open /snap/bin: no such file or directory"
# Error: bad file '-': yaml: mapping values are not allowed in this context
# ===== protect =====
ok 40 create dummy instance in 66ms

https://github.com/lima-vm/lima/actions/runs/17775630264/job/50573056648?pr=4009

@olamilekan000 olamilekan000 force-pushed the show-available-plugins-for-info-and-exec-cmd branch 2 times, most recently from 5a7b1fa to 79ef8e3 Compare September 19, 2025 02:08
Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly fine, but I still have some stylistic feedback, and some minor issues.

@olamilekan000 olamilekan000 force-pushed the show-available-plugins-for-info-and-exec-cmd branch from 79ef8e3 to 2a9a7d8 Compare September 20, 2025 23:47
@olamilekan000 olamilekan000 force-pushed the show-available-plugins-for-info-and-exec-cmd branch 3 times, most recently from 0fa884d to 74b3bc1 Compare September 21, 2025 00:27
@olamilekan000 olamilekan000 force-pushed the show-available-plugins-for-info-and-exec-cmd branch from 74b3bc1 to 6bc9696 Compare September 21, 2025 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli limactl CLI user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow command aliasing via PATH lookup
3 participants