Skip to content

Conversation

@hombit
Copy link
Collaborator

@hombit hombit commented Nov 1, 2024

No description provided.

@codecov
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 98.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.40%. Comparing base (1a2a1d2) to head (b652f7a).
Report is 49 commits behind head on main.

Files with missing lines Patch % Lines
src/nested_pandas/nestedframe/core.py 97.43% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #168      +/-   ##
==========================================
- Coverage   99.49%   99.40%   -0.10%     
==========================================
  Files          14       14              
  Lines         985     1003      +18     
==========================================
+ Hits          980      997      +17     
- Misses          5        6       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Nov 1, 2024

Before [1a2a1d2] After [b13b786] Ratio Benchmark (Parameter)
38.6±7ms 43.9±6ms ~1.14 benchmarks.ReassignHalfOfNestedSeries.time_run
7.92±0.1ms 8.18±0.3ms 1.03 benchmarks.NestedFrameQuery.time_run
1.57±0.01ms 1.59±0.02ms 1.01 benchmarks.NestedFrameReduce.time_run
266M 266M 1.00 benchmarks.AssignSingleDfToNestedSeries.peakmem_run
22.6±0.6ms 22.5±0.5ms 1.00 benchmarks.AssignSingleDfToNestedSeries.time_run
88.3M 88.1M 1.00 benchmarks.NestedFrameAddNested.peakmem_run
9.09±0.1ms 9.14±0.1ms 1.00 benchmarks.NestedFrameAddNested.time_run
93M 93.3M 1.00 benchmarks.NestedFrameQuery.peakmem_run
91.8M 91.9M 1.00 benchmarks.NestedFrameReduce.peakmem_run
285M 285M 1.00 benchmarks.ReassignHalfOfNestedSeries.peakmem_run

Click here to view all benchmarks.

@hombit hombit marked this pull request as ready for review November 6, 2024 18:03
wilsonbb and others added 2 commits November 6, 2024 10:06
Tests for using the 'on' keyword with add_nested and packing
@hombit hombit requested review from gitosaurus and wilsonbb November 6, 2024 18:15
Copy link
Contributor

@wilsonbb wilsonbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Minor suggestions including fixing one of my own typos haha

@hombit hombit merged commit 96503cd into main Nov 6, 2024
8 of 10 checks passed
@hombit hombit deleted the non-uniq-idx branch November 6, 2024 18:37
@hombit hombit restored the non-uniq-idx branch November 6, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants