Skip to content

Conversation

@hombit
Copy link
Collaborator

@hombit hombit commented Jan 27, 2025

Fix #189

@hombit hombit requested a review from dougbrn January 27, 2025 16:04
@codecov
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.44%. Comparing base (77a816d) to head (610853b).
Report is 133 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #190   +/-   ##
=======================================
  Coverage   99.43%   99.44%           
=======================================
  Files          13       13           
  Lines        1071     1074    +3     
=======================================
+ Hits         1065     1068    +3     
  Misses          6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

Before [77a816d] After [2a3bd07] Ratio Benchmark (Parameter)
32.8±5ms 33.6±6ms 1.03 benchmarks.ReassignHalfOfNestedSeries.time_run
269M 269M 1 benchmarks.AssignSingleDfToNestedSeries.peakmem_run
91.6M 91.5M 1 benchmarks.NestedFrameAddNested.peakmem_run
96.1M 96.1M 1 benchmarks.NestedFrameQuery.peakmem_run
95.3M 95.3M 1 benchmarks.NestedFrameReduce.peakmem_run
1.25±0.02ms 1.25±0.01ms 1 benchmarks.NestedFrameReduce.time_run
289M 288M 1 benchmarks.ReassignHalfOfNestedSeries.peakmem_run
10.7±0.1ms 10.6±0.1ms 0.99 benchmarks.NestedFrameQuery.time_run
25.4±0.8ms 24.8±0.2ms 0.98 benchmarks.AssignSingleDfToNestedSeries.time_run
10.3±0.3ms 9.90±0.1ms 0.96 benchmarks.NestedFrameAddNested.time_run

Click here to view all benchmarks.

Copy link
Collaborator

@dougbrn dougbrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

@hombit hombit merged commit 7a0c3bd into main Jan 27, 2025
11 checks passed
@hombit hombit deleted the flat-chunked-array-fix branch January 27, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot convert pyarrow.lib.ChunkedArray to pyarrow.lib.Array at view_sorted_series_as_list_array

3 participants