-
Notifications
You must be signed in to change notification settings - Fork 1
Add nest_lists to conveniently nest list columns
#239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #239 +/- ##
==========================================
+ Coverage 98.26% 98.27% +0.01%
==========================================
Files 14 14
Lines 1271 1279 +8
==========================================
+ Hits 1249 1257 +8
Misses 22 22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Click here to view all benchmarks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, thank you! I just have one main question
Fixes #223
Adds
nest_listswhich, similar tofrom_lists, allows to specify a set of columns which contain list-values. These list columns are then packed into a new specified nested column within a resulting NestedFrame. The original columns are of course dropped.While
from_listsis a static constructor method, here we allow fSome additional checks are added to allow for the method to not fail on an empty dataframe and to have more explicit failure messages for columns that do not contain list-values.
Change Description
Solution Description
Code Quality
Project-Specific Pull Request Checklists
New Feature Checklist
Documentation Change Checklist