Derive ShapedRun::advance from clusters#706
Merged
waywardmonkeys merged 1 commit intoJul 22, 2026
Merged
Conversation
`process_clusters` updated its `run_advance` accumulator only when it encountered the next cluster. It therefore omitted the final cluster, and a run containing one cluster reported zero advance. Derive `ShapedRun::advance` from finalized `ClusterData::advance` values instead. This makes cluster data the source of truth and removes the parallel accumulator from `process_clusters`. Add a regression test for a one-cluster run.
Contributor
Author
|
An LLM (GPT 5.6, Sol, xhigh) was involved in this with finding / identifying the issue and writing the test. |
nicoburns
approved these changes
Jul 22, 2026
tomcur
approved these changes
Jul 22, 2026
tomcur
left a comment
Member
There was a problem hiding this comment.
For additional context, see: #679 (comment).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
process_clustersupdated itsrun_advanceaccumulator only when it encountered the next cluster. It therefore omitted the final cluster, and a run containing one cluster reported zero advance.Derive
ShapedRun::advancefrom finalizedClusterData::advancevalues instead. This makes cluster data the source of truth and removes the parallel accumulator fromprocess_clusters. Using finalizedClusterData::advancevalues as the source of truth also respects transformations applied while constructing clusters, such as stripping newline glyph contribution.Add a regression test for a one-cluster run.
Performance
A repeated paired Tango comparison against
fed192afound no statistically significant regressions: