Skip to content

Conversation

@maghasemzadeh
Copy link

Resolve issue #80

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Apr 3, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.28%.

Quality metrics Before After Change
Complexity 7.24 ⭐ 7.01 ⭐ -0.23 👍
Method Length 40.18 ⭐ 42.71 ⭐ 2.53 👎
Working memory 6.53 🙂 6.73 🙂 0.20 👎
Quality 73.36% 🙂 73.08% 🙂 -0.28% 👎
Other metrics Before After Change
Lines 215 220 5
Changed files Quality Before Quality After Quality Change
rest_framework_tracking/base_mixins.py 72.27% 🙂 72.27% 🙂 0.00%
rest_framework_tracking/mixins.py 98.34% ⭐ 82.40% ⭐ -15.94% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
rest_framework_tracking/base_mixins.py BaseLoggingMixin.finalize_response 15 🙂 185 😞 9 🙂 47.60% 😞 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant