-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup deps #151
base: main
Are you sure you want to change the base?
Cleanup deps #151
Conversation
f1f2110
to
f2b5a8f
Compare
Thank you so much! This is terrific. What do you think about adding a GH action, Makefile target, and dependency stanza in the pyproject.toml with https://deptry.com/ in the loop? @multimeric @dalito e.g. makefile target would look like this:
GH action addition to "check-pull-request.yaml" would look like this:
thank you to @pkalita-lbl for pointing out deptry to us. I won't block this PR on this, but it might be a great next step! :) thanks again. |
@multimeric - All changes look fine to me. @sierra-moxon I have no experience yet with deptry but saw that you or Patrick(?) started using it. I am not sure if it would have caught the unused mkdocs here because we had another superfluous file that used mkdocs. |
Okay, I've done all the above. Current output is:
I assume all the database packages are there to facilitate SQL import. I would have no issue removing them, but I can add a DEP002 exception if you'd rather. Numpy is a bit different because it's being pinned at |
I've added all the above warnings to the ignore list. |
I would suggest to not make the deptry dependency check an action that fails the PR-checks. I tried it in other projects and it was proposing to remove dependencies which should definitely stay. For example openpyxl requires pillow to support images. However, deptry suggested to remove it. I have not checked if this is an issue with deptry or with the dependency specification in openpyxl but it shows that you may not want to block PR checks based on the deptry check or act on the results without thorough checking. |
I don't mind it failing. If you don't import |
pyproject.toml
Much of this is following the report from
fawltydeps
.