Skip to content

[CI] static analysis and Makefile improvements - #600

Open
AshleyDumaine wants to merge 4 commits into
mainfrom
go-analyze
Open

[CI] static analysis and Makefile improvements #600
AshleyDumaine wants to merge 4 commits into
mainfrom
go-analyze

Conversation

@AshleyDumaine

Copy link
Copy Markdown
Contributor

This change:

  • adds a GHA workflow for static analysis tools (gosec, vulncheck, etc) and adds fixes for gosec
  • standardizes the existing CI GHA workflow
  • updates the Makefile to handle CI (GITHUB_ACTIONS env var exists in GHA) or local environments (where you might be on a mac and not have the necessary packages for the LUKS code to work, thus requiring a container to run certain tools or tests)
  • Adds missing deps to mise.toml and fixes the specified go version (bumping to 1.26.7 as the most recent patch for 1.26)

@AshleyDumaine
AshleyDumaine requested review from a team as code owners August 26, 2026 18:22
@github-actions github-actions Bot added the repo-ci-improvement for improvements in the repository or CI workflow in the changelog. label Aug 26, 2026
@codecov

codecov Bot commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 27.27273% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.33%. Comparing base (2738615) to head (f178740).

Files with missing lines Patch % Lines
internal/driver/controllerserver_helper.go 0.00% 1 Missing and 1 partial ⚠️
internal/driver/server.go 0.00% 1 Missing and 1 partial ⚠️
pkg/filesystem/filesystem.go 0.00% 2 Missing ⚠️
pkg/linode-client/token.go 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #600      +/-   ##
==========================================
- Coverage   71.51%   71.33%   -0.18%     
==========================================
  Files          25       25              
  Lines        2243     2250       +7     
==========================================
+ Hits         1604     1605       +1     
- Misses        507      510       +3     
- Partials      132      135       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…ec, update Makefile to handle CI or local environments
Comment thread test.Dockerfile Outdated
…er, remove redundant gosec since it's already handled by golangci-lint
@AshleyDumaine
AshleyDumaine marked this pull request as ready for review August 27, 2026 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

repo-ci-improvement for improvements in the repository or CI workflow in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants