-
Notifications
You must be signed in to change notification settings - Fork 79
Fix Integration tests #600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes failing integration tests by addressing various test reliability and assertion issues. The changes focus on improving test stability, fixing timeouts, and correcting API usage patterns.
- Removes blank lines in unit test files to clean up formatting
- Updates integration tests to use proper fixture dependencies and improve error handling
- Fixes timing-sensitive assertions and test logic to reduce flakiness
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
test/unit/objects/monitor_test.py | Removes blank lines for formatting cleanup |
test/unit/objects/linode_test.py | Removes blank lines for formatting cleanup |
test/integration/models/nodebalancer/test_nodebalancer.py | Adds proper fixture dependencies and improves cleanup with error handling |
test/integration/models/firewall/test_firewall.py | Refactors tests to use existing firewall associations instead of creating new ones |
test/integration/models/account/test_account.py | Increases timeout threshold and improves event polling logic |
test/integration/helpers.py | Adds duplicate sleep call in retry logic |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
It's still failing... https://github.com/linode/linode_api4-python/actions/runs/18012149846 |
|
📝 Description
Address some of the failing tests
✔️ How to Test
make test-int TEST_CASE=test_nodebalancer.py
make test-int TEST_CASE=test_firewall.py
make test-int TEST_CASE=test_account.py
📷 Preview
If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.