Skip to content

Inform the admin symlinks were skipped when adding paths #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rmetrich wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Inform the admin symlinks were skipped when adding paths #394

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fce381
Inform the admin symlinks were skipped when adding paths
rmetrich Mar 3, 2026
b983ad9
Rework
rmetrich Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions src/cli/file-cli.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
#include <ftw.h>
#include <stdbool.h>
#include <errno.h>
#include <limits.h>
#include <stdlib.h>
#include <string.h>
#include <sys/stat.h>
Expand Down Expand Up @@ -72,6 +73,28 @@ static int ftw_add_list_append(const char *fpath,
} else {
msg(LOG_INFO, "Skipping non regular file: %s", fpath);
}
} else if (typeflag == FTW_SL) {
char target[PATH_MAX];
ssize_t len = readlink(fpath, target, sizeof (target) - 1);
if (len == -1) {
msg(LOG_ERR, "Cannot read value of symbolic link %s: %s",
fpath, strerror(errno));
return FTW_CONTINUE;
}
target[len] = '\0';
struct stat st;
if (stat(fpath, &st) == -1)
msg(LOG_WARNING, "Cannot stat symbolic link %s pointing to %s: %s",
fpath, target, strerror(errno));
else if (target[0] == '/')
msg(LOG_INFO, "Skipping symbolic link %s: "
"consider adding target %s", fpath, target);
else if (realpath(fpath, target) == NULL)
msg(LOG_WARNING, "Cannot resolve symbolic link %s: %s",
fpath, strerror(errno));
else
msg(LOG_INFO, "Skipping symbolic link %s: "
"consider adding target %s", fpath, target);
}
return FTW_CONTINUE;
}
Expand Down
Loading