-
Notifications
You must be signed in to change notification settings - Fork 112
style: Use conscious language for profile list #834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Till Maas <[email protected]>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRefactors variable naming in network_connections.py to use more inclusive and descriptive terminology while preserving existing behavior for selecting which NetworkManager profiles to keep or delete. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've left some high level feedback:
- To keep the type of
kept_profilesconsistent across both branches and avoid list vs. set semantics, initialize it as aset()whennameis truthy (instead of[]), since in theelsebranch it is a set and you are using membership checks that are more efficient on sets.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- To keep the type of `kept_profiles` consistent across both branches and avoid list vs. set semantics, initialize it as a `set()` when `name` is truthy (instead of `[]`), since in the `else` branch it is a set and you are using membership checks that are more efficient on sets.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #834 +/- ##
==========================================
+ Coverage 43.11% 43.22% +0.10%
==========================================
Files 12 12
Lines 3124 3123 -1
==========================================
+ Hits 1347 1350 +3
+ Misses 1777 1773 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
A small change to use more conscious language and more a more meaningful variable name.
Summary by Sourcery
Enhancements: