Skip to content

ci: tox-lsr 3.17.0 - container test improvements, use ansible 2.20 for fedora 43 [citest_skip]#336

Merged
richm merged 1 commit intomainfrom
ci-container-improvements
Mar 11, 2026
Merged

ci: tox-lsr 3.17.0 - container test improvements, use ansible 2.20 for fedora 43 [citest_skip]#336
richm merged 1 commit intomainfrom
ci-container-improvements

Conversation

@richm
Copy link
Collaborator

@richm richm commented Mar 11, 2026

tox-lsr 3.17.0 has some container test improvements - better output, faster runs

Use Ansible 2.20 for qemu/container tests on fedora 43

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update CI workflows to use tox-lsr 3.17.0 and Ansible 2.20 for Fedora 43 qemu and container tests, improving container test efficiency and output.

CI:

  • Bump tox-lsr to version 3.17.0 across GitHub Actions workflows used for testing and linting.
  • Switch Fedora 43 qemu and container test matrices to use Ansible core 2.20 instead of 2.19.
  • Adjust container test execution to only run requirements installation and callback plugins on the first test run to speed up subsequent runs.

…r fedora 43 [citest_skip]

tox-lsr 3.17.0 has some container test improvements - better output, faster runs

Use Ansible 2.20 for qemu/container tests on fedora 43

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@richm richm self-assigned this Mar 11, 2026
@sourcery-ai
Copy link

sourcery-ai bot commented Mar 11, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates CI workflows to use tox-lsr 3.17.0 and Ansible 2.20 for Fedora 43 environments, and adjusts container test environment variables to leverage new tox-lsr behavior for faster, clearer test runs.

File-Level Changes

Change Details Files
Bump Ansible core version to 2.20 for Fedora 43 qemu and container integration tests.
  • Update Fedora 43 qemu test matrix entry to use qemu-ansible-core-2-20 environment.
  • Update Fedora 43 container test matrix entry to use container-ansible-core-2-20 environment.
  • Update Fedora 43 bootc container test matrix entry to use container-ansible-core-2-20 environment.
.github/workflows/qemu-kvm-integration-tests.yml
Upgrade tox-lsr used in CI workflows from 3.16.0 to 3.17.0.
  • Update tox-lsr version in qemu-kvm integration tests workflow.
  • Update tox-lsr version in ansible-lint workflow.
  • Update tox-lsr version in ansible-managed-var-comment workflow.
  • Update tox-lsr version in ansible-test workflow.
.github/workflows/qemu-kvm-integration-tests.yml
.github/workflows/ansible-lint.yml
.github/workflows/ansible-managed-var-comment.yml
.github/workflows/ansible-test.yml
Adjust container test loop to take advantage of tox-lsr 3.17.0 optimizations via environment flags.
  • Remove previous workaround disabling container profile and pretty output environment variables.
  • Initialize SKIP_REQUIREMENTS and SKIP_CALLBACK_PLUGINS to false before the first container test run.
  • Set SKIP_REQUIREMENTS and SKIP_CALLBACK_PLUGINS to true after each test iteration to speed up subsequent runs.
.github/workflows/qemu-kvm-integration-tests.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@richm richm merged commit bb330e6 into main Mar 11, 2026
12 checks passed
@richm richm deleted the ci-container-improvements branch March 11, 2026 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant