ci: tox-lsr 3.17.1 - previous update broke container tests, this fixes them [citest_skip]#337
Merged
ci: tox-lsr 3.17.1 - previous update broke container tests, this fixes them [citest_skip]#337
Conversation
…s them [citest_skip] tox-lsr 3.17.1 has a fix for the broken container tests There was one shell function for both setting up the callback plugins and the connection plugin. When this function was skipped, the ANSIBLE_CONNECTION_PLUGINS environment variable was not set, so all subsequent tests failed. The connection plugin must be present and the env. var. must be set in order to run any container tests. The code was fixed to ensure that there is always a connection plugin installed in the correct location and that ANSIBLE_CONNECTION_PLUGINS is always set and contains this path. Also, setting up the callback plugins and the connection plugin is already idempotent, so no reason to skip them. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates GitHub Actions workflows to use tox-lsr 3.17.1 (which fixes broken container tests) and stops skipping callback/connection plugin setup between test runs so ANSIBLE_CONNECTION_PLUGINS is always set for container tests. Sequence diagram for container test run with tox_lsr 3_17_1 ensuring ANSIBLE_CONNECTION_PLUGINS is setsequenceDiagram
actor Developer
participant GitHubActions as GitHub_Actions_Workflow
participant Tox as tox
participant ToxLSR as tox_lsr_3_17_1
participant Ansible as ansible_test_container
Developer->>GitHubActions: push_changes
GitHubActions->>GitHubActions: pip_install_tox_lsr_3_17_1
GitHubActions->>Tox: run_tox_env_for_container_tests
Tox->>ToxLSR: initialize_role_testenv
alt plugin_setup_invocation
ToxLSR->>ToxLSR: install_connection_plugin
ToxLSR->>ToxLSR: install_callback_plugins
ToxLSR->>ToxLSR: set_env_ANSIBLE_CONNECTION_PLUGINS
else plugin_setup_was_skipped_in_previous_version
ToxLSR-->>Tox: connection_plugin_missing
Tox-->>GitHubActions: test_setup_failure
end
ToxLSR->>Tox: testenv_ready_with_connection_plugin
Tox->>Ansible: run_container_tests
Ansible-->>GitHubActions: report_test_results
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tox-lsr 3.17.1 has a fix for the broken container tests
There was one shell function for both setting up the callback plugins and the connection plugin.
When this function was skipped, the ANSIBLE_CONNECTION_PLUGINS environment variable was not
set, so all subsequent tests failed. The connection plugin must be present and the env. var.
must be set in order to run any container tests. The code was fixed to ensure that there is
always a connection plugin installed in the correct location and that ANSIBLE_CONNECTION_PLUGINS
is always set and contains this path.
Also, setting up the callback plugins and the connection plugin is already idempotent, so no
reason to skip them.
Signed-off-by: Rich Megginson rmeggins@redhat.com
Summary by Sourcery
Update CI workflows to use tox-lsr 3.17.1 and adjust container test configuration to restore container test execution.
Bug Fixes:
CI: