Support SUT customizations via plugins #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define ComChannel class for communication channels implementations which will be SSH, LTX, shell, Qemu, etc. Signed-off-by: Andrea Cervesato <[email protected]> com: handle ComChannel plugins via libkirk.com Signed-off-by: Andrea Cervesato <[email protected]>
acerv
force-pushed
the
new_com
branch
2 times, most recently
from
a2173e5 to
6024c5c
Compare
metan-ucw
approved these changes
Oct 14, 2025
Member
metan-ucw
left a comment
metan-ucw
left a comment
There was a problem hiding this comment.
You can add my Reviewed-by: Cyril Hrubis [email protected]
Member
There was a problem hiding this comment.
This should probably be removed from the patch that adds ssh COM, or is there a reason to remove it here?
Collaborator
Author
There was a problem hiding this comment.
I noticed that. Probably I messed up with rebase...need to fix it
Create channels folder and add shell implementation in there. Signed-off-by: Andrea Cervesato <[email protected]>
Signed-off-by: Andrea Cervesato <[email protected]>
Signed-off-by: Andrea Cervesato <[email protected]>
Signed-off-by: Andrea Cervesato <[email protected]>
Signed-off-by: Andrea Cervesato <[email protected]>
Signed-off-by: Andrea Cervesato <[email protected]>
Signed-off-by: Andrea Cervesato <[email protected]>
Add clone() method to Plugin API and extend it to the plugins implementations. Add libkirk.com.clone_channel() to follow this pattern and to clone new channels inside the application. Signed-off-by: Andrea Cervesato <[email protected]>
Signed-off-by: Andrea Cervesato <[email protected]>
Signed-off-by: Andrea Cervesato <[email protected]>
Signed-off-by: Andrea Cervesato <[email protected]>
Signed-off-by: Andrea Cervesato <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patche-set introduces new API for the
SUTinterface as well as a newComChannelclass, that is our new API for protocols communication (for example, SSH, shell, LTX, Qemu, etc).With this patch-set it's possible to create new customized
SUTwhich needs more protocols to run at the same time for setting up, for example, hardware, remote controllers, etc. Kirk will take care of discovering new implementations via the--pluginsoption and it will assign any channel configuration via--comoption.With the
--comoption it will be possible to define up to 128 communication channels per session, where each one of them will have a special assignedidthat can be used to recognize our channels inside theSUTvialibkirk.com.get_channels()API.In short, this patch-set permits to instantiate multiple communication channels (aka protocols) per
SUT, providing a simple interface to the user that will be able to customize kirk for their own scenarios.Please take a look at the new documentation under
doc/developers/plugins.rst.Reviewed-by: Cyril Hrubis [email protected]
Signed-off-by: Andrea Cervesato [email protected]