session: implement forcibly stop #83
Merged
+35
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acerv
force-pushed
the
force_stop
branch
4 times, most recently
from
c73e750 to
200f221
Compare
metan-ucw
requested changes
Nov 14, 2025
Member
metan-ucw
left a comment
metan-ucw
left a comment
There was a problem hiding this comment.
Looks good to me, minus the unconditional handling for SIGKILL in the ltp,py. If that is fixed you can add my Reviewed-by: Cyril Hrubis [email protected]
acerv
force-pushed
the
force_stop
branch
4 times, most recently
from
a2c6293 to
da185ec
Compare
metan-ucw
reviewed
Nov 18, 2025
Change the way we complete session by introducing forcibly stop. The way that kirk works after this patch is the following: - if user sends SIGINT or CTRL+C, we simply wait for the running tests to complete and finally stop the session - if user sends SIGINT or CTRL+C again, we stop any execution on the SUT and we terminate the testing suite, flagging the killed test as TSKIP Reviewed-by: Cyril Hrubis <[email protected]> Signed-off-by: Andrea Cervesato <[email protected]> Closes: linux-test-project#78
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the way we complete session by introducing forcibly stop. The
way that kirk works after this patch is the following:
if user sends SIGINT or CTRL+C, we simply wait for the running
tests to complete and finally stop the session
if user sends SIGINT or CTRL+C again, we stop any execution on the SUT
and we terminate the testing suite, flagging the killed test as TSKIP
Reviewed-by: Cyril Hrubis [email protected]
Signed-off-by: Andrea Cervesato [email protected]
Closes: #78