Skip to content

Conversation

@jay763190097
Copy link

No description provided.

@RandallPittmanOrSt
Copy link

Comments from a passerby who doesn't know much about the Timeshift source:

  1. There should be a description of what problem this PR is addressing.
  2. .vscode folder does not belong and should be removed. Also the changes to .gitignore shouldn't be merged.
  3. Files changed seem to show that the author is making other (probably benign, but I don't know) changes that aren't related to the PR title.

1 and 3 are big red flags to me.

@jay763190097
Copy link
Author

Hi @RandallPittmanOrSt,

  1. I'll add a description and its related issue number.
  2. I'll remove .vscode and changes in .gitignore
  3. That's because I met an issue related pkexec, and I fixed it via this approach.

@jay763190097
Copy link
Author

jay763190097 commented Jun 18, 2025

@RandallPittmanOrSt This PR is trying to implement the requirement for #348 #357 #198.

@mtwebster
Copy link
Member

Hi,

I'm good with adding a way to specify a config file, but this PR seems to be doing a number of other things:

  • Please remove anything related to .vscode
  • Do not modify the changelog or version in the root meson.build file.
  • What is scdoc for in the build instructions? This isn't necessary for the build
  • Get rid of new policykit file and related files.

Thanks

@jay763190097
Copy link
Author

jay763190097 commented Aug 28, 2025

Hi @mtwebster

  • Please remove anything related to .vscode
  • Do not modify the changelog or version in the root meson.build file.
  • What is scdoc for in the build instructions? This isn't necessary for the build

May need your advice for the last item, caused that i want to add the below environment parameter and the previous one doesn't work for me.

export DISPLAY=$DISPLAY
export XAUTHORITY=$XAUTHORITY

If I just run this command from timeshift-launcher file

pkexec env DISPLAY=$DISPLAY XAUTHORITY=$XAUTHORITY timeshift-gtk
image

We can see the pkexec path is wrong, it doesn't match

<annotate key="org.freedesktop.policykit.exec.path">/usr/bin/timeshift-gtk</annotate>

@jay763190097
Copy link
Author

jay763190097 commented Aug 28, 2025

  • Get rid of new policykit file and related files.

@mtwebster @RandallPittmanOrSt All items are done, Pls help to check.

@jay763190097
Copy link
Author

@mtwebster Hey, May I know when do we plan to merge this PR.

@jay763190097
Copy link
Author

Solution for #198 #348 #357

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants