Skip to content

EMQX add#733

Closed
christianleo333 wants to merge 0 commit into
linuxserver:masterfrom
christianleo333:master
Closed

EMQX add#733
christianleo333 wants to merge 0 commit into
linuxserver:masterfrom
christianleo333:master

Conversation

@christianleo333

Copy link
Copy Markdown

No description provided.

@mvdkleijn

Copy link
Copy Markdown
Collaborator

Hi @christianleo333 Can I ask you why you used the enhanced app template instead of the foundation app template? Clearly you did not implement any enhanced functionality...

@mvdkleijn

Copy link
Copy Markdown
Collaborator

Also, some of the checka failed.

@mvdkleijn

Copy link
Copy Markdown
Collaborator

Hi please double check your icon. Apparently the icon size is 0x0 px, whereas it should be a min of 100px and max 250 px (from memory)

@mvdkleijn

Copy link
Copy Markdown
Collaborator

hi @christianleo333 the test is still failing (see below).

Please ensure the png is at least 100x100 px and at most 250x250 px. (and square obviously)

2024-05-24T15:38:07.8935627Z ##[group]Run node testRunner.js
node testRunner.js
shell: /usr/bin/bash -e {0}
Running Tests
Icon is too small: { width: 87, height: 100 }

Testing EMQX
Failed: should have an Icon with min width 100px and min height 100px when PNG

Some Tests Failed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants