-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added iptables-legacy to installed packages #26
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this pull request! Be sure to follow the pull request template!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This provides a resolution to #25.
If this PR gets merged, it is recommended that the documentation in https://github.com/linuxserver/fail2ban-confs be updated to advise users to the availability of both iptables
backends and how to choose between them in conf files. I'm happy to open an issue and subsequently a PR there once (and if) this PR gets merged.
I am a bot, here are the test results for this PR:
|
I am a bot, here are the test results for this PR:
|
I am a bot, here are the test results for this PR:
|
I am a bot, here are the test results for this PR:
|
I am a bot, here are the test results for this PR:
|
I see no reason to not add this in, we do this in swag for fail2ban also. once #29 is merged, this will need to be updated against that. Apologies for the delays on this, it slipped our notice, but at least you get some hacktoberfest credit for it now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't be an issue to merge this. I don't think it has any effect until the confs are changed. A previous comment mentioned updating the docs in the config repo as well.
Description:
The recent rebase to Alpine 3.19 broke the functionality on hosts which use iptables such as Unraid. This PR also installs the Alpine package
iptables-legacy
so that users on these systems may still use the container. This PR fixes #25.Benefits of this PR and context:
The container is unusable on hosts which only have iptables. With this PR it will remain usable.
How Has This Been Tested?
Installed a container on two computers, one which is an Unraid system and another an Arch linux system. The Unraid one uses iptables while the Arch one uses nftables. I configured fail2ban to monitor ssh on each, and an entry was added to the tables for ssh as expected. After multiple test unsuccessful attempts it blocked me afterwards. @danielaranki performed a similar test last week and showed his findings in #25.
The user will need to specify in their jail.local file which backend to use (also pointed out by @danielaranki in #25):