Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite playbook logic #327

Merged
merged 5 commits into from
Feb 9, 2025
Merged

Rewrite playbook logic #327

merged 5 commits into from
Feb 9, 2025

Conversation

Roxedus
Copy link
Member

@Roxedus Roxedus commented Feb 6, 2025

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

  • Restructure files
    • Use catatonit
    • Remove CI server page
    • Move ansible stuff to ansible/ to distinguish ansible files from other files
  • Move away from template loop
    • Introduce inventory, silences implicit localhost message
    • Split up loop to dedicated roles
      • Easier to not run certain processes, ie deprecation
      • Makes testing easier, can run the documentation role if you only did documentation changes
        • Introduce role tags
    • Un-macro the macros. As the new logic used multiple roles, and these roles share the macro, introduce the macro as a ansible variable that can be included on top of the template
    • Sets sane permissions for templated files. Executable files gets the executable flag, non-executables doesn't

Benefits of this PR and context:

How Has This Been Tested?

Source / References:

@Roxedus Roxedus requested a review from a team February 6, 2025 11:29
@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/jenkins-builder/00e8d47e-pkg-00e8d47e-dev-62486a5a649cda395c19f494931c69f5d91237ab-pr-327/index.html
https://ci-tests.linuxserver.io/lspipepr/jenkins-builder/00e8d47e-pkg-00e8d47e-dev-62486a5a649cda395c19f494931c69f5d91237ab-pr-327/shellcheck-result.xml

Tag Passed
amd64-00e8d47e-pkg-00e8d47e-dev-62486a5a649cda395c19f494931c69f5d91237ab-pr-327
arm64v8-00e8d47e-pkg-00e8d47e-dev-62486a5a649cda395c19f494931c69f5d91237ab-pr-327

Copy link
Member

@thespad thespad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good as best I can tell without the ability to test running actual random builds with it.

@Roxedus Roxedus merged commit 6e9bf95 into monthly Feb 9, 2025
7 checks passed
@Roxedus Roxedus deleted the rewrite branch February 9, 2025 21:38
@Roxedus Roxedus mentioned this pull request Feb 10, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants