Create internal.conf #520
Create internal.conf #520
Conversation
Add a single conf file that can be used in proxy-confs via "include /config/nginx/internal.conf" for a single point of management for allowed IPs.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thanks for opening this pull request! Be sure to follow the pull request template!
Changed from explicit IP ranges to using an included config file. Recommend this shouldn't be merged upstream unless linuxserver/docker-swag#520 is as well. Signed-off-by: hellblazer315 <[email protected]>
|
I am a bot, here are the test results for this PR:
|
|
I am a bot, here is the pushed image/manifest for this PR:
|
|
I am a bot, here is the pushed image/manifest for this PR:
|
|
I am not seeing any value here. Many users create an allowdeny.conf or internal.conf to use as they see fit, but prepopulating ip ranges, especially external ones in a file named internal.conf just seems odd to me. Yes, i understand the reason you put tailscale ips in there, no it doesnt make them internal ips. this type of change is best left up to the individual users to handle. with that said, thank you for your effort in creating this PR, filling out the template appropriately, and sharing your code with us! |
Add a single conf file that can be used in proxy-confs via "include /config/nginx/internal.conf" for a single point of management for allowed IPs.
EDIT: Completed template.
Description:
Added an internal.conf that specifies common internal IP ranges and tailscale's default range. Blocks access from all other IPs with a 403.
Benefits of this PR and context:
Provides a single place to specify approved IP ranges that may be used across multiple proxy-confs via "include /config/nginx/internal.conf".
How Has This Been Tested?
Yes, had the same snippet within the file in my dashboard.subdomain.conf. Removed that in exchange for "include /config/nginx/internal.conf" and access is still restricted to local IPs.
Source / References:
N/A