Skip to content

Conversation

@Douglas-K
Copy link
Contributor

Fixes:
Comparisons was taking too long and was timing out when run in Production.
It appears this was getting hung around the RECURSIVE function when comparing for Related buildings. This is used for identifying and tracking many-to-many relationships between new and old buildings.

Change Description:

Comparing for Related buildings is now turned off (via commenting out the relevant sections). These will now be treated as Added and Removed buildings instead. This is the pragmatic approach, instead of spending a lot of time refactoring.

Consequentially, the NZ Building Outlines Lifecycle table is no longer being updated.

NOTE: This change is not updated in Sqitch because we are unlikely to use Sqitch in the future.

Notes for Testing:

...

Source Code Documentation Tasks:

  • README updated (where applicable)
  • CHANGELOG (Unreleased section) updated
  • Docstrings / comments included to help explain code

User Documentation Tasks:

  • Confluence user guide updated (where applicable)

Testing Tasks:

  • Added tests that fail without this change
  • All tests are passing in development environment
  • Reviewers assigned
  • Linked to main issue for ZenHub board

@Douglas-K Douglas-K requested a review from jducnuigeen October 29, 2025 00:40
@Douglas-K Douglas-K self-assigned this Oct 29, 2025
Copy link
Contributor

@jducnuigeen jducnuigeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working through these !

@Douglas-K
Copy link
Contributor Author

Failed attempts to update the Tests by replacing Related features with Adds and Deletes.
This would take a large amount of effort to update the Tests correctly and is currently a low priority, so is put on hold for now.
In the meantime, the changes above are being reverted back and this PR will be closed.

@Douglas-K Douglas-K closed this Nov 3, 2025
@Douglas-K Douglas-K deleted the compare_related branch November 3, 2025 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants