fix: related comparisons turned off #659
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
Comparisons was taking too long and was timing out when run in Production.
It appears this was getting hung around the RECURSIVE function when comparing for Related buildings. This is used for identifying and tracking many-to-many relationships between new and old buildings.
Change Description:
Comparing for Related buildings is now turned off (via commenting out the relevant sections). These will now be treated as Added and Removed buildings instead. This is the pragmatic approach, instead of spending a lot of time refactoring.
Consequentially, the NZ Building Outlines Lifecycle table is no longer being updated.
NOTE: This change is not updated in Sqitch because we are unlikely to use Sqitch in the future.
Notes for Testing:
...
Source Code Documentation Tasks:
User Documentation Tasks:
Testing Tasks: