You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We are somewhat inconsitent in our yaml styles, some things are quoted where they shouldn't need to be quoted.
This is a first draft of applying a linter, I have tried to use the default rules where they don't conflict with prettier as we already use prettier for the yaml formatting.
Modifications
Installs eslint-plugin-yml yaml linter and adds it to eslint to be run on every pull request
We should probably not trust too much the argo lint --offline templates/ workflows/ and actually test the workflows modified by this PR before merging?
build still builds, testing jobs still runs
maybe we need to run some of the workflowTemplate too?
We should probably not trust too much the argo lint --offline templates/ workflows/ and actually test the workflows modified by this PR before merging?
build still builds, testing jobs still runs
maybe we need to run some of the workflowTemplate too?
I agree, do we have any easy way to run tests off a pull request?
We should probably not trust too much the argo lint --offline templates/ workflows/ and actually test the workflows modified by this PR before merging?
build still builds, testing jobs still runs
maybe we need to run some of the workflowTemplate too?
I agree, do we have any easy way to run tests off a pull request?
That would be nice to do something like what have been removed here but deleting the "test" namespace only when the PR is merged so during the time the PR is opened we can test the workflows on that namespace.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We are somewhat inconsitent in our yaml styles, some things are quoted where they shouldn't need to be quoted.
This is a first draft of applying a linter, I have tried to use the default rules where they don't conflict with prettier as we already use prettier for the yaml formatting.
Modifications
Installs
eslint-plugin-ymlyaml linter and adds it to eslint to be run on every pull requestVerification
build still builds, testing jobs still runs