-
Notifications
You must be signed in to change notification settings - Fork 2
build: add yaml linter #986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
We should probably not trust too much the
maybe we need to run some of the workflowTemplate too? |
I agree, do we have any easy way to run tests off a pull request? |
That would be nice to do something like what have been removed here but deleting the "test" namespace only when the PR is merged so during the time the PR is opened we can test the workflows on that namespace. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's necessary to apply these changes on the examples in the different readmes, but they may be inconsistent in their format now?
Motivation
We are somewhat inconsitent in our yaml styles, some things are quoted where they shouldn't need to be quoted.
This is a first draft of applying a linter, I have tried to use the default rules where they don't conflict with prettier as we already use prettier for the yaml formatting.
Modifications
Installs
eslint-plugin-ymlyaml linter and adds it to eslint to be run on every pull requestVerification
build still builds, testing jobs still runs