-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAT-18148: refactorings + tests #175
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ChangeObjectTests
require to have the expectedSnapshot
file to work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although the checkboxes are green, there are failed tests https://github.com/liquibase/liquibase-databricks/pull/175/checks?check_run_id=29317521268
Does the workflow have errors?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The expectedSql file is there... but the SQL is incorrect because we depend on the core fix .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About expectedSnapshots: I used createTableDataTypeText.xml as an example and there is no expectedSnapshot to it, just sql... weird
@filipelautert |
Thanks @vitaliimak , I just pushed an empty one. |
0737fa9
to
8d417fe
Compare
Quality Gate passedIssues Measures |
The following changeset will create auto increment/generated columns:
Nothing was required on databricks side, please see companion PR in core: liquibase/liquibase#6263