Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix main build dependencies for tests #183

Merged
merged 9 commits into from
Mar 15, 2024
Merged

Fix main build dependencies for tests #183

merged 9 commits into from
Mar 15, 2024

Conversation

filipelautert
Copy link
Contributor

No description provided.

@filipelautert filipelautert requested a review from jandroav March 14, 2024 18:22
@filipelautert filipelautert self-assigned this Mar 14, 2024
filipelautert
filipelautert commented Mar 15, 2024
View reviewed changes
pom.xml Outdated
@@ -71,10 +65,18 @@
<artifactId>postgresql</artifactId>
<version>42.7.2</version>
</dependency>
this should not build
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jandroav but it is building! Seems we are always building master instead of the pr.

feat(test.yml): add pull_request event types 'opened', 'reopened', an…
037c8f3 
…d 'synchronize' to trigger workflow on these actions
chore(pom.xml): remove unnecessary comment "this should not build" to…
5c9e4a2 
… clean up the file and improve readability
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@filipelautert filipelautert merged commit b8ca440 into main Mar 15, 2024
19 of 28 checks passed
@filipelautert filipelautert deleted the fix-spock-error branch March 15, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jandroav jandroav Awaiting requested review from jandroav

Assignees

@filipelautert filipelautert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filipelautert @jandroav