feat(identity): add STS credential management #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liramon1
force-pushed
the
sts-credentials
branch
from
57cd7e7 to
1d30f5e
Compare
liramon1
force-pushed
the
iam-credentials
branch
from
9b69727 to
fdd5dfe
Compare
liramon1
force-pushed
the
sts-credentials
branch
from
35d8bd1 to
7a8e61a
Compare
* change error handling to 429 * add unit tests
liramon1
force-pushed
the
sts-credentials
branch
from
7a8e61a to
48a1bc5
Compare
…ors (aws#1969) This PR adds comprehensive logging to the Amazon Q Developer Profiles fetching process to help diagnose the "failed to fetch: developerProfiles" error that customers are experiencing with ATX transformation. The enhanced logging captures detailed information about endpoints accessed, regions queried, profiles returned, and provides structured error details without modifying any existing functionality. Key improvements: - Log all endpoints and regions being queried - Capture raw API responses and request parameters - Track profile retrieval success/failure by region - Provide detailed error information including HTTP status codes and AWS metadata - Summarize total profiles fetched across all regions These changes will help identify the root cause of login issues by providing visibility into the profile fetching process. * feat: enhance profile fetching logs to diagnose developerProfiles errors * feat: enhance profile fetching logs and add exception handling for debugging * feat: enhance profile fetching logs and add exception handling for debugging * refactor: remove unused endpoint parameter from fetchProfilesFromRegion
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
liramon1
force-pushed
the
iam-credentials
branch
from
fdd5dfe to
6f37a8a
Compare
liramon1
force-pushed
the
sts-credentials
branch
2 times, most recently
from
99f379d to
7c5acf0
Compare
* feat: mcpmanager changes to support http/sse * fix: fix mcp sse transport headers issue * fix: fix unit tests for mcp http/sse support * feat: ux changes for mcp http/sse support * feat: ux changes for mcp http/sse support
* feat: adding inline chat telemetry * feat: adding error metrics, updating the names of params --------- Co-authored-by: Supraja Venkatesh <[email protected]>
The identity LSP was changed to load and save IAM profile kinds.
liramon1
force-pushed
the
sts-credentials
branch
2 times, most recently
from
0921ebe to
f06d8a6
Compare
liramon1
force-pushed
the
sts-credentials
branch
from
f06d8a6 to
9345d1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The identity LSP does not support retrieving IAM role credentials. This forces IDE extensions to implement IAM credentials retrieval, which leads to code duplication and added complexity.
Solution
This is part of aws#1685 and is built on top of aws#1869. This will be copied into aws#1846 when merged.
This PR adds the option to assume a role and generate STS credentials if the language client requests an IAM credential using a RoleSourceProfile. After the STS credential is generated, the identity LSP caches it into .aws/cli/cache and manages its lifecycle, including expiration, invalidation, and refresh.
Note: This PR currently fails the CI pipeline because it depends on changes from aws/language-server-runtimes#599.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.