Added pause/resume, paused channel queries and music time functions #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coerce is no longer needed. Multiplying "position" by 1.0d0 (a double-float number) coerces it without calling an expensive function.
|
Heya @ReinUsesLisp, looks good! I'd probably prefer that instead of |
|
btw, sorry it's taken us so long to get to this. It would be ace to get this in soon. |
|
@cbaggers Sure. #'float is easier to understand. An implicit division is better than an explicit multiplication (and better than a #'coerce call). |
|
It's best if you change it. Thanks! |
|
btw sorry that this didnt get done I'll try get to it soon. Your work here really is appreciated |
|
If anyone is still interested, can they rebase this so that it works on the current |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take a look at #'set-music-position, is it OK to call #'coerce there?
Edit: Multiplying by 1.0d0 coerces a number to double-float type.