Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: docker compose shell command #40

Merged
merged 3 commits into from
Jul 29, 2023
Merged

fix: docker compose shell command #40

merged 3 commits into from
Jul 29, 2023

Conversation

Faolain
Copy link
Contributor

@Faolain Faolain commented Jul 28, 2023

Currently integration tests fail due to the docker_service timing out which itself is a result of thedocker compose command not running correctly due to a shell error. This works on mac 13.2 with zsh & ohmyzsh.

However I'm getting this on my own branch for Github Actions:
Screenshot 2023-07-28 at 2 16 00 PM

Unsure if it's related to the changes on my PR.

Copy link
Member

@cofin cofin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cofin cofin merged commit 891e732 into litestar-org:master Jul 29, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants