-
-
Notifications
You must be signed in to change notification settings - Fork 6
docs: use literalinclude instead of code-block on quickstart #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@cofin I just moved things around, are examples folder in the docs tested somehow, I didnt take the time to investigate but I'm sure you'll know :) |
show just the snippet and not the test
|
re-reading this after i'm on other pages I realize that for instance we could do differently: current option1: could be option2: and we use dedent like in the async test on this pr, idk which one is better:
|
If there's no change in the user output, I definitely think that a single function is much easier to maintain here. I'd go with option 2 as well. |
Description
code-blockin their owntest_xxxfiles and useliteralincludein the quickstart.rst/docs/examples/quickstartto pytest discover pathCloses
fixes #167