Add chaos engine name while creating Experiment Job #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mviswanathsai
requested review from
ispeakc0de,
ksatchit and
uditgaurav
as code owners
mviswanathsai
force-pushed
the
log-chaosengine-name
branch
from
b6375f5 to
ae5632e
Compare
Signed-off-by: mviswanathsai <[email protected]>
mviswanathsai
force-pushed
the
log-chaosengine-name
branch
from
ae5632e to
f79ceff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #223Special notes for your reviewer: I am not 100% on this change yet. Kindly take a look at it and let me know what format we are going for here. I am also open to changing the other logs from adding strings to formatting it with
Sprintfif that's something the maintainers are fine with.Checklist:
documentationtagbreaking-changestagrequires-upgradetag