Skip to content

Conversation

@HossamSaberr
Copy link
Contributor

@HossamSaberr HossamSaberr commented Nov 3, 2025

What type of PR is this? (check all applicable)

  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • ♻️ Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert
  • 🌐 Internationalization / Translation

Description

This PR updates the typescript and @typescript/vfs packages to their latest stable versions.

  • typescript: updated from 5.6.2 to 5.9.3
  • @typescript/vfs: updated from 1.5.3 to 1.6.1

Related Tickets & Documents

#875

Mobile & Desktop Screenshots/Recordings

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentations?

  • πŸ““ docs (./docs)
  • πŸ“• storybook (./storybook)
  • πŸ“œ README.md
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

None.

[optional] What gif best describes this PR or how it makes you feel?

Summary by CodeRabbit

  • Chores
    • Updated the embedded TypeScript runtime and virtual file system to newer patch releases, improving editor/runtime performance, language features and compatibility with recent TypeScript code.

@netlify
Copy link

netlify bot commented Nov 3, 2025

βœ… Deploy Preview for livecodes ready!

Name Link
πŸ”¨ Latest commit 956285f
πŸ” Latest deploy log https://app.netlify.com/projects/livecodes/deploys/690b2853f797b200085cea40
😎 Deploy Preview https://deploy-preview-911--livecodes.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link

coderabbitai bot commented Nov 3, 2025

Walkthrough

Replaced two vendored CDN URLs in src/livecodes/vendors.ts: typescriptUrl now points to TypeScript v5.9.3 and typescriptVfsUrl now points to @typescript/vfs v1.6.1. No other functional or control-flow changes found.

Changes

Cohort / File(s) Summary
Vendored runtime URLs
src/livecodes/vendors.ts
Updated typescriptUrl to https://cdn.../[email protected]/lib/typescript.js and typescriptVfsUrl to https://cdn.../@typescript/[email protected]/dist/vfs.esm.js (version bumps only).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Single-file change updating CDN/version strings.
  • Review focus:
    • Verify the updated CDN URLs resolve and load in target environments.
    • Run TypeScript compile and any VFS-dependent flows to detect compatibility issues.

Pre-merge checks and finishing touches

βœ… Passed checks (2 passed)
Check name Status Explanation
Description Check βœ… Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check βœ… Passed The title accurately summarizes the main change: updating TypeScript to v5.9.3, which is the primary purpose of the pull request.
✨ Finishing touches
  • πŸ“ Generate docstrings
πŸ§ͺ Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

πŸ“œ Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between 3fc3672 and 956285f.

πŸ“’ Files selected for processing (1)
  • src/livecodes/vendors.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/livecodes/vendors.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
  • GitHub Check: build
  • GitHub Check: build (18.x)
  • GitHub Check: tests (18.x, 4)
  • GitHub Check: tests (18.x, 3)
  • GitHub Check: tests (18.x, 1)
  • GitHub Check: tests (18.x, 5)
  • GitHub Check: tests (18.x, 2)
  • GitHub Check: Redirect rules - livecodes
  • GitHub Check: Codacy Static Code Analysis
  • GitHub Check: Header rules - livecodes
  • GitHub Check: Pages changed - livecodes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

πŸ“œ Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between 4163d1d and d1181b8.

πŸ“’ Files selected for processing (1)
  • src/livecodes/vendors.ts (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Codacy Static Code Analysis
  • GitHub Check: Redirect rules - livecodes
  • GitHub Check: Header rules - livecodes
  • GitHub Check: Pages changed - livecodes
πŸ”‡ Additional comments (1)
src/livecodes/vendors.ts (1)

440-440: The core premise of this review comment is incorrect.

TypeScript 5.9.3 is the latest version, and the change from 5.6.2 to 5.9.3 is an upgrade, not a downgrade. In semantic versioning, 5.9.x is newer than 5.6.x. The PR correctly fulfills its objective to keep TypeScript up to date.

However, there is one legitimate concern: @typescript/vfs latest version is 1.6.1, not 1.6.2 as referenced on line 442. Update the version to 1.6.1.

Likely an incorrect or invalid review comment.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 5, 2025

@hatemhosny
Copy link
Collaborator

Thank you @HossamSaberr

@hatemhosny hatemhosny merged commit 2d1d304 into live-codes:develop Nov 5, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants