-
-
Notifications
You must be signed in to change notification settings - Fork 198
Update typescript to v5.9.3 #911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update typescript to v5.9.3 #911
Conversation
β Deploy Preview for livecodes ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
WalkthroughReplaced two vendored CDN URLs in Changes
Estimated code review effortπ― 2 (Simple) | β±οΈ ~10 minutes
Pre-merge checks and finishing touchesβ Passed checks (2 passed)
β¨ Finishing touches
π§ͺ Generate unit tests (beta)
π Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro π Files selected for processing (1)
π§ Files skipped from review as they are similar to previous changes (1)
β° Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
π Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
π Files selected for processing (1)
src/livecodes/vendors.ts(2 hunks)
β° Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: Redirect rules - livecodes
- GitHub Check: Header rules - livecodes
- GitHub Check: Pages changed - livecodes
π Additional comments (1)
src/livecodes/vendors.ts (1)
440-440: The core premise of this review comment is incorrect.TypeScript 5.9.3 is the latest version, and the change from 5.6.2 to 5.9.3 is an upgrade, not a downgrade. In semantic versioning, 5.9.x is newer than 5.6.x. The PR correctly fulfills its objective to keep TypeScript up to date.
However, there is one legitimate concern: @typescript/vfs latest version is 1.6.1, not 1.6.2 as referenced on line 442. Update the version to 1.6.1.
Likely an incorrect or invalid review comment.
|
|
Thank you @HossamSaberr |



What type of PR is this? (check all applicable)
Description
This PR updates the
typescriptand@typescript/vfspackages to their latest stable versions.typescript: updated from5.6.2to5.9.3@typescript/vfs: updated from1.5.3to1.6.1Related Tickets & Documents
#875
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentations?
[optional] Are there any post-deployment tasks we need to perform?
None.
[optional] What gif best describes this PR or how it makes you feel?
Summary by CodeRabbit