Skip to content

Prepare pages for Teams launch #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

hugobarauna
Copy link
Member

No description provided.

Copy link

netlify bot commented Apr 24, 2025

Deploy Preview for livebook-dev ready!

Name Link
🔨 Latest commit cfe3e90
🔍 Latest deploy log https://app.netlify.com/sites/livebook-dev/deploys/680b898968cef1000822e488
😎 Deploy Preview https://deploy-preview-112--livebook-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@josevalim
Copy link
Contributor

I would personally keep the new "switch" link aligned to the menu on the right, like this:

Screenshot 2025-04-24 at 17 06 05

And I would also add "Livebook Teams" on the left side, to make it clear this is a Livebook Teams page. Finally, I would add some vertical padding (2px) to the bar, as right now it is very tight.

Btw, here is how it looks with the blue bar, not sure if we want to keep it too:

image

@hugobarauna
Copy link
Member Author

I would personally keep the new "switch" link aligned to the menu on the right, like this:

Screenshot 2025-04-24 at 17 06 05 And I would also add "Livebook Teams" on the left side, to make it clear this is a Livebook Teams page. Finally, I would add some vertical padding (2px) to the bar, as right now it is very tight.

Btw, here is how it looks with the blue bar, not sure if we want to keep it too:

image

@josevalim done in 5d62cf5

As we talked, feel free to play with it.

Copy link
Contributor

@josevalim josevalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed my last suggestions. It is up to you if you want to go with the Livebook Teams text at the top or not.

Also, remember to not merge it now. Only when we roll out the changes. :)

@hugobarauna
Copy link
Member Author

@josevalim

I pushed my last suggestions. It is up to you if you want to go with the Livebook Teams text at the top or not.

Also, remember to not merge it now. Only when we roll out the changes. :)

Thanks, applied all of them.

Let's maintain the "Livebook Teams" context text at the switch/context banner. 👍

@hugobarauna
Copy link
Member Author

Ok, this is done. ✅

We'll merge it when all tasks needed to move Teams out of beta are done.

@hugobarauna hugobarauna changed the title Prepare pages for for Teams launch Prepare pages for Teams launch Apr 24, 2025
@jonatanklosko
Copy link
Member

I am not a fan of the darkened pink. Here's an alternative (I also adjusted the link a bit):

image

It is your call though!

@hugobarauna
Copy link
Member Author

I am not a fan of the darkened pink. Here's an alternative (I also adjusted the link a bit):

image It is your call though!

@jonatanklosko great, I think I prefer your version as well. Can you push those changes?

@jonatanklosko
Copy link
Member

@hugobarauna pushed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants