-
Notifications
You must be signed in to change notification settings - Fork 15
Prepare pages for Teams launch #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for livebook-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Inline <style> and <script> code is bundled by astro, so they don't appear on the page as is. So, we're keeping them at the end for clarity.
@josevalim done in 5d62cf5 As we talked, feel free to play with it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed my last suggestions. It is up to you if you want to go with the Livebook Teams text at the top or not.
Also, remember to not merge it now. Only when we roll out the changes. :)
Co-authored-by: José Valim <[email protected]>
Co-authored-by: José Valim <[email protected]>
Co-authored-by: José Valim <[email protected]>
Thanks, applied all of them. Let's maintain the "Livebook Teams" context text at the switch/context banner. 👍 |
Ok, this is done. ✅ We'll merge it when all tasks needed to move Teams out of beta are done. |
@jonatanklosko great, I think I prefer your version as well. Can you push those changes? |
@hugobarauna pushed! |
No description provided.