Target Rails 7.1 #39
Merged
Target Rails 7.1 #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade to Rails 7.1 (specs fail under 7.2). ARJDBC does not currently support Rails 7.1. Update the Gemfile to target the source, and target jruby-head to keep CI passing.
liveh2o
force-pushed
the
ah/rails-7-1
branch
from
4df97fe to
9d94c58
Compare
The CI workflow was only running the adapter specs. Add a job that runs the remaining gem tests as well.
liveh2o
force-pushed
the
ah/rails-7-1
branch
from
9d94c58 to
048310f
Compare
Rails now handles filtering views from the tables query, so these overrides are no longer needed.
Owner
Author
|
ARDBC doesn't officially support Rails 7.1 yet, but with a small tweak handle MySQL results, specs are all passing against the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting a branch started with Rails 7.1 support. Specs are passing under Ruby, but not JRuby. Guessing something changed with the adapters...