Add agent video support #11
Conversation
1egoman
force-pushed
the
fix-scrolling-and-add-video
branch
from
202df47 to
070685f
Compare
1egoman
force-pushed
the
fix-scrolling-and-add-video
branch
from
070685f to
067d914
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Big issue though: I can't get the animation fade in to look decent, the problem is the video element shows up before the data stream fully starts which means regular fade in animations mostly happen while the video is black which makes them invisible
1egoman
force-pushed
the
fix-scrolling-and-add-video
branch
from
067d914 to
14b9b4f
Compare
|
I have rebased this pull request on top of the latest @thomasyuill-livekit I updated the demo video in the pull request description, but the note about the animation not being all that great still stands. I'm tempted to just merge this given it's something it seems like is being requested exist in the demo. That being said, if you have any suggestions for a better animation (given the challenges with the video animation potentially starting while the video is black), I'd be more than willing to work with you to make it happen. |
1egoman
changed the title
|
This is great. I think we can merge as is and fix forward. I also think we should remove the audio visualizer when we have an avatar/video element as it does not provide much value. |
Adds agent video support to the popup style embed. Right now the behavior is that if a video track is published by an agent, the video track is shown, covering up the transcriptions. There's no way for now to programmatically switch which one is visible.
Note
Important callout: I am not totally satisfied yet with the animation when the video is initially shown. It turns out this is kinda a tricky problem to do well because the video track / associated
<video>element shows up and begins animating in before the video stream has fully initialized, leading to the first half of the animation being in practice hard to see with a dark video background over a dark popup background.Demo
Screen.Recording.2025-09-05.at.10.43.37.AM.mov
(note - no sound is expected, I didn't capture it as part of the demo)
## A few other smaller assorted things:Fix the message scroll behavior - previously, there was a bug that led to no message scrollback, so users could only see the messages on the screen and that was it.Migrate to the pre-existingagent-starter-reactroom connection code - this logic nicely handles enabling the microphone before the room may be fully connected, so a user can start speaking ASAP.