Skip to content

Add support for API key and secret in STTOptions and SpeechStream #3039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

51750
Copy link

@51750 51750 commented Jul 29, 2025

This PR adds support for hardcoded credentials in the AWS STT integration.

In #2297, api_key and api_secret were removed by @davidzhao to simplify the interface. While this improved usability, it also reduced flexibility. In certain cases—such as when environment variables or IAM roles are unavailable—users may still need to provide credentials manually.

This update restores that flexibility by reintroducing support for explicit credential configuration. It aligns with AWS best practices, which also allow manual credential setup when needed, while remaining compatible with existing authentication mechanisms.

@51750 51750 force-pushed the aws-stt-credentia branch 3 times, most recently from 9547105 to b58a519 Compare July 29, 2025 09:32
@longcw longcw requested a review from davidzhao July 29, 2025 09:35
@51750 51750 force-pushed the aws-stt-credentia branch from b58a519 to db5ba07 Compare July 29, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant