Skip to content

Fix packaging issue in livekit-ffi #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2025
Merged

Conversation

typester
Copy link
Member

@typester typester commented Mar 4, 2025

Definitions of dependencies without specifying versions cause a packaging issue in livekit-ffi. Using a workspace definition resolves this.

We don't use a published crate for FFI, so this doesn't block any releases of foreign language SDKs, but I will fix this just in case.

@typester typester requested review from bcherry and davidzhao March 4, 2025 17:50
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg.. though I haven't seen this before

@typester
Copy link
Member Author

typester commented Mar 4, 2025

lg.. though I haven't seen this before

I feel the same way. I'm wondering why there was no issue before.
Anyway I've found a related issue: rust-lang/cargo#11133
It looks like it might be fixed in the future.

@typester typester merged commit 8e3e1b1 into main Mar 4, 2025
8 checks passed
@typester typester deleted the typester/fix-ffi-packaging-issue branch March 4, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants