Allow passing in TLS configuration#609
Closed
ConradIrwin wants to merge 2 commits intolivekit:mainfrom
Closed
Conversation
Contributor
|
it seems like you haven't added any nanpa changeset files to this PR. if this pull request includes changes to code, make sure to add a changeset, by writing a file to refer to the manpage for more information. |
4526e6a to
220fd8e
Compare
220fd8e to
c4b4540
Compare
This was referenced Oct 20, 2025
Contributor
|
Conflicting changes have been merged since this was opened. I rebased it on the current main branch in #755. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes it possible for users of the library to pass their own TLS
It also bumps to the latest tokio-tungstenite so that the version of rustls in
use matches what we are using at Zed.
We've been through a number of different possible rustls connectors, and we're
currently using one (rustls-platform-verifier) that doesn't have feature flags
in livekit or tungstenite yet.
Instead of requiring that every transitive dependency supports the rustls feature flags we need,
it's much easier to pass only the
__rustls-tlsfeature flag and pass the Connectorthat we create with our configuration down the stack.
The main disadvantage of this approach is that if you use the
__rustls-tlsflag, and don't pass a Connector, you get a panic when connecting to a wss://
URL.