Fix build failure on macOS for developers who have multiple clang installations #697
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The webrtc-sys build script was using
Command::new("clang")
to discover compiler library paths. On a system with Homebrew's llvm package installed, this command could resolve to/usr/local/bin/clang
instead of the required Xcode toolchain compiler.This caused the script to pass incorrect library search paths to the linker, resulting in errors like:
Solution
The fix is to change
Command::new("clang")
toCommand::new("cc")
within theconfigure_darwin_sysroot
function in build.rs.On macOS,
cc
is the system's default compiler alias and is guaranteed to respect the toolchain set byxcode-select
. This ensures that even if other versions of clang are in the PATH, the build script will always get the correct search paths from the active Xcode toolchain.This makes the build process more robust and resilient to variations in the user's local environment.