Livepeer.Cloud SPE - add windows build #3366
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikezupper
force-pushed
the
tasks/livepeer.cloud/add-windows-support
branch
from
a5f7933 to
164ee83
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3366 +/- ##
=============================================
Coverage 31.91887% 31.91887%
=============================================
Files 169 169
Lines 41217 41217
=============================================
Hits 13156 13156
Misses 27071 27071
Partials 990 990 see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
mikezupper
force-pushed
the
tasks/livepeer.cloud/add-windows-support
branch
from
164ee83 to
f18c976
Compare
Member
|
we were installing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
This provides a docker build for Windows binaries. This was in response to the Bounty published by @rickstaa
livepeer/bounties#62
Specific updates (required)
How did you test each of these updates (required)
The build ran successfully on Livepeer.Cloud's CI/CD environment. The windows binary was deployed to a windows server and properly started. (testing on the actual transcoding was NOT done)
Does this pull request close any open issues?
No
Checklist:
makeruns successfully./test.shpass