Skip to content

Conversation

@moudi-network
Copy link

What does this pull request do? Explain your changes

This PR adds a CLI warning when an orchestrator attempts to unbond their entire stake. This prevents accidental deactivation of orchestrators by requiring explicit confirmation before proceeding with a full unbond.

Specific updates (required)

  • Added a check in the unbond() function to detect when an orchestrator (self-delegated) is unbonding their full bonded amount
  • Added a warning message explaining that full unbond will deactivate the orchestrator
  • Added a y/n confirmation prompt to prevent accidental full unbonds

How did you test each of these updates (required)

Does this pull request close any open issues?

Checklist:

  • Read the contribution guide
  • make runs successfully (fails due to pre-existing lpms/ffmpeg dependency issue locally)
  • All tests in ./test.sh pass ( FAIL: TestRingbuffer_ConcurrentRW (1.81s) )
  • README and other documentation updated
  • Pending changelog updated

@github-actions github-actions bot added the go Pull requests that update Go code label Jan 7, 2026
@rickstaa rickstaa requested a review from j0sh January 8, 2026 09:26
Copy link
Collaborator

@j0sh j0sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK to me, might be good for orchestrator-developers to get eyes on this too ... cc @ad-astra-video @eliteprox

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go Pull requests that update Go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants